feat(core): Add SignalAbs trait for numeric signals

argus-core/src/signals/cast.rs

@@ -2,7 +2,7 @@ use itertools::Itertools;
 use num_traits::{Num, NumCast};
 
 use crate::signals::traits::SignalNumCast;
-use crate::signals::{AnySignal, ConstantSignal, Signal};
+use crate::signals::{ConstantSignal, Signal};
 
 macro_rules! impl_cast {
     ($type:ty) => {

argus-core/src/signals/cmp_ops.rs

@@ -2,7 +2,7 @@ use std::cmp::Ordering;
 
 use num_traits::NumCast;
 
-use super::traits::{BaseSignal, LinearInterpolatable, SignalMinMax, SignalPartialOrd};
+use super::traits::{BaseSignal, LinearInterpolatable, SignalMinMax, SignalPartialOrd, SignalSyncPoints};
 use super::utils::sync_with_intersection;
 use super::{ConstantSignal, InterpolationMethod, Signal};
 
@@ -109,13 +109,15 @@ where
     }
 }
 
-impl<T> SignalMinMax for Signal<T>
+impl<T, Lhs, Rhs> SignalMinMax<Rhs> for Lhs
 where
     T: PartialOrd + Copy + num_traits::NumCast + LinearInterpolatable,
+    Lhs: SignalSyncPoints<Rhs> + BaseSignal<Value = T>,
+    Rhs: SignalSyncPoints<Self> + BaseSignal<Value = T>,
 {
     type Output = Signal<T>;
 
-    fn min(&self, other: &Self) -> Self::Output {
+    fn min(&self, other: &Rhs) -> Self::Output {
         let time_points = sync_with_intersection(self, other).unwrap();
         time_points
             .into_iter()
@@ -131,7 +133,7 @@ where
             .collect()
     }
 
-    fn max(&self, other: &Self) -> Self::Output {
+    fn max(&self, other: &Rhs) -> Self::Output {
         let time_points = sync_with_intersection(self, other).unwrap();
         time_points
             .into_iter()

argus-core/src/signals/num_ops.rs

@@ -1,6 +1,6 @@
 use num_traits::{Num, NumCast, Signed};
 
-use super::traits::{BaseSignal, LinearInterpolatable};
+use super::traits::{BaseSignal, LinearInterpolatable, SignalAbs};
 use crate::signals::utils::{apply1, apply2, apply2_const, sync_with_intersection};
 use crate::signals::{ConstantSignal, Signal};
 
@@ -282,3 +282,45 @@ where
         apply2(self, other, |lhs, rhs| lhs.pow(rhs))
     }
 }
+
+macro_rules! signal_abs_impl {
+    (const $( $ty:ty ), *) => {
+        $(
+        impl SignalAbs for ConstantSignal<$ty> {
+            /// Return the absolute value for the signal
+            fn abs(&self) -> ConstantSignal<$ty> {
+                ConstantSignal::new(self.value.abs())
+            }
+        }
+        )*
+    };
+
+    ($( $ty:ty ), *) => {
+        $(
+        impl SignalAbs for Signal<$ty> {
+            /// Return the absolute value for each sample in the signal
+            fn abs(&self) -> Signal<$ty> {
+                apply1(self, |v| v.abs())
+            }
+        }
+        )*
+    };
+}
+
+signal_abs_impl!(i64, f32, f64);
+
+impl SignalAbs for Signal<u64> {
+    /// Return the absolute value for each sample in the signal
+    fn abs(&self) -> Signal<u64> {
+        apply1(self, |v| v)
+    }
+}
+
+signal_abs_impl!(const i64, f32, f64);
+
+impl SignalAbs for ConstantSignal<u64> {
+    /// Return the absolute value for the signal
+    fn abs(&self) -> ConstantSignal<u64> {
+        ConstantSignal::new(self.value)
+    }
+}

argus-core/src/signals/traits.rs

@@ -266,20 +266,20 @@ where
     }
 }
 
-impl<T> SignalSyncPoints<ConstantSignal<T>> for ConstantSignal<T>
-where
-    T: Copy,
-    Self: BaseSignal<Value = T>,
-{
-    type Output<'a> = Empty<&'a Duration>
-    where
-        Self: 'a,
-        Self: 'a;
-
-    fn synchronization_points<'a>(&'a self, _other: &'a ConstantSignal<T>) -> Option<Self::Output<'a>> {
-        Some(core::iter::empty())
-    }
-}
+// impl<T> SignalSyncPoints<ConstantSignal<T>> for ConstantSignal<T>
+// where
+//     T: Copy,
+//     Self: BaseSignal<Value = T>,
+// {
+//     type Output<'a> = Empty<&'a Duration>
+//     where
+//         Self: 'a,
+//         Self: 'a;
+//
+//     fn synchronization_points<'a>(&'a self, _other: &'a ConstantSignal<T>) ->
+// Option<Self::Output<'a>> {         Some(core::iter::empty())
+//     }
+// }
 
 impl<T> SignalSyncPoints<Signal<T>> for ConstantSignal<T>
 where
@@ -356,3 +356,8 @@ pub trait SignalNumCast {
     fn to_f32(&self) -> Option<Self::Output<f32>>;
     fn to_f64(&self) -> Option<Self::Output<f64>>;
 }
+
+/// Trait for computing the absolute value of the samples in a signal
+pub trait SignalAbs {
+    fn abs(&self) -> Self;
+}

argus-core/src/signals/utils.rs

@@ -109,11 +109,11 @@ where
     Some(return_points)
 }
 
-pub fn apply1<T, F>(signal: &Signal<T>, op: F) -> Signal<T>
+pub fn apply1<T, U, F>(signal: &Signal<T>, op: F) -> Signal<U>
 where
     T: Copy,
-    F: Fn(T) -> T,
-    Signal<T>: std::iter::FromIterator<(Duration, T)>,
+    F: Fn(T) -> U,
+    Signal<U>: std::iter::FromIterator<(Duration, U)>,
 {
     signal.iter().map(|(t, v)| (*t, op(*v))).collect()
 }